Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.11.0 #386

Merged
merged 1 commit into from
Aug 11, 2017
Merged

v3.11.0 #386

merged 1 commit into from
Aug 11, 2017

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Aug 11, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

@codecov
Copy link

codecov bot commented Aug 11, 2017 •
edited

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          44       44           
  Lines        1235     1235           
  Branches      184      184           
=======================================
  Hits         1099     1099           
  Misses        136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ee821a...24beac0. Read the comment docs.

@aoberoi aoberoi merged commit 145d7f0 into slackapi:master Aug 11, 2017
@aoberoi aoberoi deleted the rel-v3.11.0 branch August 11, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydewael shaydewael shaydewael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aoberoi @shaydewael